migrator: remove unsigned migration support #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase with no conflicts. |
tjkirch
approved these changes
Jul 16, 2020
etungsten
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of #966 which was reverted in #971, the text below is the same as what appeared in #966.
Issue number:
Closes #972
Closes #954
Related to #961
Description of changes:
Removes support for unsigned datastore migrations. CAUTION: this code is incompatible with versions less than 0.4.x. See #961 regarding strategy for ensuring hosts do not try to upgrade or downgrade to an incompatible version of Bottlerocket.
Testing done:
Created a test migration that adds a setting "foo" with value "bar".
Ran an instance, upgraded to a higher version that included the test migration, downgrade back to original version. Along the way I verified that a pod could run, and that the migration actually ran (and affected the "foo" setting).
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.