imghelper: disable pkix in nss #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In NSS 3.101, lib::pkix was enabled as the default X.509 validator. This causes pesigcheck to fail with "Peer's Certificate issuer is not recognized," despite the CA issuer being provided to pesigcheck. We will revert to the previous validator while working to become compatible with pkix.
jpculp
approved these changes
Jul 25, 2024
vyaghras
approved these changes
Jul 25, 2024
|
We've opted to instead include this fix in the SDK itself in bottlerocket-os/bottlerocket-sdk#194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
During image creation, bottlerocket uses the
pesigcheckutility to verify secureboot signatures on all signed artifacts. The signature validation is implemented via libnss.The next Bottlerocket SDK release will move to NSS 3.101.
In NSS 3.101, lib::pkix was enabled as the default X.509 validator. This causes pesigcheck to fail with "Peer's Certificate issuer is not recognized," despite the CA issuer being provided to pesigcheck.
This change sets
NSS_DISABLE_PKIX_VERIFY=1, which reverts to the previous default verifier.I've opened #334 to root-cause the changes in pkix which cause the issue. We will revert to the previous validator while working to become compatible with pkix.
Testing done:
0.42.0and test artifacts for0.43.0.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.