imghelper: remove full path from .vmlinuz.hmac #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hmac generation moved to `imghelper`, the `vmlinuz` variable went from the basename to the full-path. This makes sure that the full-path doesn't make it into the final artifact. Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
bcressey
approved these changes
Jul 26, 2024
jpculp
commented
Jul 26, 2024
rpkelly
approved these changes
Jul 26, 2024
cbgbt
approved these changes
Jul 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When hmac generation moved to
imghelper, thevmlinuzvariable went from the basename to the full-path. This makes sure that the full-path doesn't make it into the final artifact.Also adds a missing ShellCheck exception.
Testing done:
Built and smoke tested Bottlerocket.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.