-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use cargo dist for binary releases #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
force-pushed
the
tools-install
branch
from
September 6, 2023 19:47
03e54a7
to
b6c81c3
Compare
webern
force-pushed
the
tools-install
branch
5 times, most recently
from
September 7, 2023 16:27
49c31da
to
9035614
Compare
webern
force-pushed
the
tools-install
branch
from
September 7, 2023 18:39
9035614
to
82cb765
Compare
webern
force-pushed
the
tools-install
branch
from
September 7, 2023 18:44
82cb765
to
6ebb528
Compare
18 tasks
webern
force-pushed
the
tools-install
branch
2 times, most recently
from
September 8, 2023 19:37
8a945cf
to
c6b7e09
Compare
webern
force-pushed
the
tools-install
branch
from
September 11, 2023 17:35
c6b7e09
to
cda4f71
Compare
webern
force-pushed
the
dist-pr
branch
2 times, most recently
from
September 11, 2023 20:51
900636b
to
c2a5236
Compare
webern
force-pushed
the
tools-install
branch
from
September 11, 2023 22:55
cda4f71
to
544cf34
Compare
bcressey
reviewed
Sep 12, 2023
webern
force-pushed
the
tools-install
branch
from
September 12, 2023 19:08
3b8a4ca
to
82bcb33
Compare
webern
force-pushed
the
dist-pr
branch
2 times, most recently
from
September 12, 2023 19:14
4720301
to
3320145
Compare
webern
force-pushed
the
tools-install
branch
from
September 12, 2023 19:56
82bcb33
to
5406dc0
Compare
webern
force-pushed
the
tools-install
branch
2 times, most recently
from
September 13, 2023 03:17
14a9919
to
c152c8b
Compare
webern
force-pushed
the
dist-pr
branch
2 times, most recently
from
September 13, 2023 16:19
bed0b06
to
318c0b7
Compare
webern
force-pushed
the
tools-install
branch
2 times, most recently
from
September 13, 2023 17:20
97aa59f
to
552f924
Compare
webern
force-pushed
the
dist-pr
branch
3 times, most recently
from
September 13, 2023 17:44
7dcb747
to
fb68124
Compare
webern
force-pushed
the
tools-install
branch
from
September 13, 2023 21:44
552f924
to
9af3a99
Compare
webern
force-pushed
the
tools-install
branch
from
September 13, 2023 22:12
9af3a99
to
84b795a
Compare
bcressey
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "customize cargo dist" commit doesn't mention aarch64
webern
force-pushed
the
tools-install
branch
from
September 13, 2023 22:51
84b795a
to
158e517
Compare
webern
force-pushed
the
dist-pr
branch
3 times, most recently
from
September 13, 2023 23:05
204efaa
to
06ec413
Compare
webern
force-pushed
the
tools-install
branch
from
September 14, 2023 00:06
a527e07
to
ace7b30
Compare
Run cargo dist init on the repository. This gives us new metadata in the workspace Cargo.toml and a new GitHub Actions file, release.yml.
Change cargo dist settings to give us the Rust targets that we want (musl for both x86_64 and aarch64). Change release.yml to support cross compilation.
webern
added a commit
to webern/twoliter
that referenced
this pull request
Sep 14, 2023
use cargo dist for binary releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #48
Description of changes:
Produce a new GitHub Actions workflow for publishing releases based on tags and adding binary builds to the releases.
Testing
This was tested extensively on my fork and it worked:
There will be a fair amount of tag churn getting this working for the first time. These will be
v0.0.3-rc1
etc. Once everything is working av0.0.3
tag will be produced and the rc's can be deleted from the git repo to clean things up. I will write up a release procedure in a maintainers section of the README but will need some experience with it first.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.