Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cargo dist for binary releases #49

Merged
merged 3 commits into from
Sep 14, 2023
Merged

use cargo dist for binary releases #49

merged 3 commits into from
Sep 14, 2023

Conversation

webern
Copy link
Contributor

@webern webern commented Sep 6, 2023

Issue #, if available:

Closes #48

Description of changes:

Produce a new GitHub Actions workflow for publishing releases based on tags and adding binary builds to the releases.

Testing

This was tested extensively on my fork and it worked:

There will be a fair amount of tag churn getting this working for the first time. These will be v0.0.3-rc1 etc. Once everything is working a v0.0.3 tag will be produced and the rc's can be deleted from the git repo to clean things up. I will write up a release procedure in a maintainers section of the README but will need some experience with it first.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@webern webern force-pushed the tools-install branch 5 times, most recently from 49c31da to 9035614 Compare September 7, 2023 16:27
@webern webern force-pushed the tools-install branch 2 times, most recently from 8a945cf to c6b7e09 Compare September 8, 2023 19:37
@webern webern force-pushed the dist-pr branch 2 times, most recently from 900636b to c2a5236 Compare September 11, 2023 20:51
@webern webern marked this pull request as ready for review September 11, 2023 23:15
CHANGELOG.md Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "customize cargo dist" commit doesn't mention aarch64

Run cargo dist init on the repository. This gives us new metadata in the
workspace Cargo.toml and a new GitHub Actions file, release.yml.
Change cargo dist settings to give us the Rust targets that we want
(musl for both x86_64 and aarch64). Change release.yml to support cross
compilation.
Base automatically changed from tools-install to develop September 14, 2023 00:12
@webern webern merged commit 6a06194 into develop Sep 14, 2023
1 check passed
@webern webern deleted the dist-pr branch September 14, 2023 00:21
webern added a commit to webern/twoliter that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable binary releases
2 participants