pubsys: switch to tough async #98
Conversation
|
Fix cargo deny issues (including temporary fixes). Squash to one commit. |
|
Eliminate extra runtime creations and use |
|
Small fixups from my own comments. |
| let _permit = cloned_sem.acquire().await.context(error::SemaphoreSnafu)?; | ||
| download_target(cloned_repo, cloned_target).await | ||
| }; | ||
| tasks.spawn(fut); |
There was a problem hiding this comment.
This could spawn an unbounded number of tasks. Before reading this code, my understanding was that if we are using the multi-threaded runtime this could therefor result in an unbounded number of OS threads being spawned. After re-reading the runtime docs it seems like the number of OS threads is bound to the number of CPU cores.
In the past I've used buffered_unordered to limit the number of tasks as well, which seems slightly safer but it is certainly more complex.
|
Attempt to use buffered_unordered. Will test. |
|
Restore |
Issue #, if available:
Description of changes:
Use the new async version of tough and tuftool
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.