Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend/cli: run: Allow multiple arguments to pass to executable #2342

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Conversation

psydvl
Copy link
Contributor

@psydvl psydvl commented Dec 2, 2022

frontend/cli: run: Allow multiple arguments to pass to executable and escape them

E.g.

bottles-cli run -b bottle -e x.exe arg1 arg2
bottles-cli run -b bottle -e x.exe -- --arg1=val arg2

Fixes #2305

Will break expected functionality: --args now not expected

frontend/cli: run: Append or replace new arguments, if program launched

if program X launched with default arguments defargs:

bottles-cli run -b bottle -p X arg1 arg2
x defargs arg1 arg2
bottles-cli run -b bottle -p X --args-replace arg1 arg2
x arg1 arg2

backend: create_desktop_entry: Let .desktop file listening for additional arguments

.desktop file now listen for new arguments

Allow something like this:

xdg-mime default bottle--telegram--1111.1111.desktop x-scheme-handler/tg
xdg-open tg://settings # will open installed in bottles telegram settings # NB: not checked

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Just check it works in separate python file :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: bottles-cli run ARGS parsing(?) error
2 participants