Keyboard Shortcut Improvements #2683
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes sure the list view gets properly updated when deleting a bottle
update_bottles already updates the config so this is not necessary
|
Currently shortcuts are available but we would ideally want them to be context dependent, for example we wouldn't want "New Bottle" shortcut to be available when the user is inside a existing bottle. |
Pylint result on modfied files: |
|
Can you rename |
Yes i'll update that |
cyberphantom52
force-pushed
the
keyboard_shortcuts
branch
from
983aef5
to
ac9cf19
Compare
cyberphantom52
force-pushed
the
keyboard_shortcuts
branch
from
9060022
to
252334f
Compare
TheEvilSkeleton
suggested changes
Jun 24, 2023
| self.__create_action('new', self.__new_bottle, ['<primary>n']) | ||
| self.__create_action('switch_to_bottles_page', self.__show_bottles_view, ['<alt>1']) | ||
| self.__create_action('switch_to_library_page', self.__show_library_view, ['<alt>2']) | ||
| self.__create_action('go_back', self.__go_back, ['<alt>Left']) |
There was a problem hiding this comment.
Adding Escape would help.
Suggested change
| self.__create_action('go_back', self.__go_back, ['<alt>Left']) | |
| self.__create_action('go_back', self.__go_back, ['<alt>Left', 'Escape']) |
| self.win.stack_main.set_visible_child_name("page_list") | ||
|
|
||
| def __go_back(self, *_args): | ||
| self.win.main_leaf.navigate(Adw.NavigationDirection.BACK) |
There was a problem hiding this comment.
I tested it locally and it doesn't work well in practice. Instead of going back a page, it goes to the main page when I press Alt+Left:
2023-06-24.08-39-24.mp4
There was a problem hiding this comment.
I noted this too, thats why i didn't add this once to the keyboard shortcuts window, the reason for this being we have two separate leaflets, this should be fixed automatically when we switch to AdwNavigationView.
|
Is this still a draft? |
Last i remember, there was this issue #2683 (comment) Apart from that i think this just needs a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aims to add standard keyboard shortcuts to bottles for easier access to certain actions. Also adds a shortcuts window.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.