Skip to content

Commit

Permalink
✨ Finish Docker module, 📝 add Readme, 🚀 v1.2.0
Browse files Browse the repository at this point in the history
  • Loading branch information
boul2gom committed Mar 25, 2022
1 parent 8d8b0bd commit 8efb73b
Show file tree
Hide file tree
Showing 14 changed files with 939 additions and 43 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @Yggdrasil80
1 change: 1 addition & 0 deletions .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
github: [Yggdrasil80]
19 changes: 19 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG_REPORT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
name: Bug report
about: Report a bug with this project
title: 'bug:'
labels: bug
assignees: Yggdrasil80

---

### 🐛 What's the bug ?
The Pair class io.github.yggdrasil80.types.Pair is not working properly, I can't serialize it without problems.

### 🔍 In which context, with which version of the library, and with which code did you encounter the problem ?
This issue appears in the release 1.2.0 of the library, with this code:
```java
final String serialized = new Gson().toJson(new Pair<>(1, 2));
```

### 📸 Additional details / screenshots
3 changes: 0 additions & 3 deletions .github/workflows/ci-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:

MAVEN_USERNAME: ${{ github.actor }}
MAVEN_TOKEN: ${{ secrets.MAVEN_TOKEN }}

GITHUB_USERNAME: ${{ github.actor }}
GITHUB_TOKEN: ${{ secrets.YGG_TOKEN }}

Expand All @@ -52,9 +51,7 @@ jobs:

MAVEN_USERNAME: ${{ github.actor }}
MAVEN_TOKEN: ${{ secrets.MAVEN_TOKEN }}

GITHUB_USERNAME: ${{ github.actor }}
GITHUB_TOKEN: ${{ secrets.YGG_TOKEN }}

GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
7 changes: 2 additions & 5 deletions .github/workflows/ci-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ name: Github CI - Production

on:
push:
branches: [ master ]
tags:
- 'v*'

jobs:
build:
Expand All @@ -26,7 +27,6 @@ jobs:

MAVEN_USERNAME: ${{ github.actor }}
MAVEN_TOKEN: ${{ secrets.MAVEN_TOKEN }}

GITHUB_USERNAME: ${{ github.actor }}
GITHUB_TOKEN: ${{ secrets.YGG_TOKEN }}

Expand All @@ -36,7 +36,6 @@ jobs:
name: YggTools-Doc
path: build/docs/aggregateJavadoc


doc:
needs: build
runs-on: ubuntu-latest
Expand Down Expand Up @@ -80,9 +79,7 @@ jobs:

MAVEN_USERNAME: ${{ github.actor }}
MAVEN_TOKEN: ${{ secrets.MAVEN_TOKEN }}

GITHUB_USERNAME: ${{ github.actor }}
GITHUB_TOKEN: ${{ secrets.YGG_TOKEN }}

GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public PullImageCallback pullImage(@NotNull String image, String tag, String pla
if (tag != null) cmd.withTag(tag);
if (platform != null) cmd.withPlatform(platform);
if (registry != null) cmd.withRegistry(registry);
if (auth != null) cmd.withAuthConfig(auth); else cmd.withAuthConfig(this.manager.getClient().authConfig());
if (auth != null) cmd.withAuthConfig(auth);

return cmd.exec(new PullImageCallback(image, tag)).awaitCompletion();
} catch (InterruptedException e) {
Expand All @@ -95,7 +95,7 @@ public PushImageCallback pushImage(@NotNull String image, String tag, AuthConfig
final PushImageCmd cmd = this.manager.getClient().pushImageCmd(image);

if (tag != null) cmd.withTag(tag);
if (auth != null) cmd.withAuthConfig(auth); else cmd.withAuthConfig(this.manager.getClient().authConfig());
if (auth != null) cmd.withAuthConfig(auth);

return cmd.exec(new PushImageCallback(image, tag)).awaitCompletion();
} catch (InterruptedException e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public DockerInfoManager(DockerManager manager) {
public AuthResponse authToRegistry(AuthConfig authConfig) {
final AuthCmd cmd = this.manager.getClient().authCmd();

if (authConfig != null) cmd.withAuthConfig(authConfig); else cmd.withAuthConfig(this.manager.getClient().authConfig());
if (authConfig != null) cmd.withAuthConfig(authConfig);

LOGGER.info("Authenticating to registry...");
return cmd.exec();
Expand Down
Loading

0 comments on commit 8efb73b

Please sign in to comment.