Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software Design: Sequence Diagram - Annotate #118

Closed
4 tasks done
onurkomurcu opened this issue Apr 6, 2022 · 4 comments
Closed
4 tasks done

Software Design: Sequence Diagram - Annotate #118

onurkomurcu opened this issue Apr 6, 2022 · 4 comments
Assignees
Labels
diagrams Related to use-case/class/sequence diagrams priority-high High level priority issue Status: Completed Issue is solved type-system design System design related

Comments

@onurkomurcu
Copy link
Contributor

onurkomurcu commented Apr 6, 2022

Issue Description

We were started to make sequence diagrams. I will make a sequence diagram which is related to annotation.

Use Case Diagram:
Ekran Resmi 2022-04-06 09 10 58

Class Diagram:
Ekran Resmi 2022-04-06 09 11 18

Step Details

Steps that will be performed:

  • Analyze annotation related diagrams which are provided above.
  • Research about how to implement sequence diagram.
  • Create the diagram in Lucidchart.
  • Provide screenshot of the work.

Final Actions

After the work is done, it will be merged with our teammates' works.

Deadline of the Issue

06.04.2022 - Wednesday - 10.00

Reviewer

Ezgi Aysel Batı

Deadline for the Review

06.04.2022 - Wednesday - 11.00

@onurkomurcu onurkomurcu added priority-high High level priority issue status-new New issue in initial state diagrams Related to use-case/class/sequence diagrams type-system design System design related labels Apr 6, 2022
@onurkomurcu onurkomurcu self-assigned this Apr 6, 2022
@onurkomurcu onurkomurcu added status-inprogress Issue is currently worked and removed status-new New issue in initial state labels Apr 12, 2022
@onurkomurcu
Copy link
Contributor Author

I select the create action for the annotation sequence diagram. It is ready to be reviewed now.

Ekran Resmi 2022-04-12 19 39 19

@onurkomurcu onurkomurcu added status-needreview A review to the issue is needed and removed status-inprogress Issue is currently worked labels Apr 12, 2022
@ezgy
Copy link
Contributor

ezgy commented Apr 13, 2022

Thank you for your work, @onurkomurcu. I have a few suggestions to improve this diagram:

  • instead of directly adding the created object to the DB, the diagram can include the Annotation class and the connection through the Enrollment class.
  • once there are multiple classes communicating, you should also consider that return/reply messages are generally represented with dashed lines.

@ezgy ezgy added status-waitingresponse Author needs to review suggestions given. and removed status-needreview A review to the issue is needed labels Apr 13, 2022
@onurkomurcu
Copy link
Contributor Author

onurkomurcu commented Apr 13, 2022

I revised my work after your review, @ezgy . The points you have mentioned can be observed in the following diagram. If you have any further question or suggestion, let me know. If not, you can close this issue. Thank you for your contribution.

Ekran Resmi 2022-04-13 21 19 08

PS: @egemenatikk help me to revise the sequence diagram. I want to thank him too.

@xltvy xltvy added Status: Completed Issue is solved and removed status-waitingresponse Author needs to review suggestions given. labels Apr 13, 2022
@xltvy
Copy link
Contributor

xltvy commented Apr 13, 2022

Closed #118

@xltvy xltvy closed this as completed Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagrams Related to use-case/class/sequence diagrams priority-high High level priority issue Status: Completed Issue is solved type-system design System design related
Projects
None yet
Development

No branches or pull requests

3 participants