Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Practice app/feature/get lesson events endpoint 186 #191

Merged

Conversation

egemenatikk
Copy link
Contributor

This PR includes the following actions:

  1. Check whether the incoming data is valid or not
  2. Check whether a lesson with the given lesson_id exists or not.
  3. Return events array for the lesson with the given lesson_id
  4. Return an error message if an error occurs in any of the previous steps
  5. Test the endpoint with Postman
  6. Save requests as a collection in Postman
  7. Document the endpoint

Now, the get lesson events endpoint is ready for requests.

This PR closes #186, other details can also be seen from that issue.

@egemenatikk egemenatikk added practice-app Related to the practice app project practice-app:back-end Related to the back-end of the practice app labels May 16, 2022
@egemenatikk egemenatikk requested review from xltvy and surmelienes1 May 16, 2022 19:30
@egemenatikk egemenatikk self-assigned this May 16, 2022
Copy link
Contributor

@surmelienes1 surmelienes1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems very good and complete, thank you @egemenatikk for your valuable contributions.

I will now merge these changes with the master branch and automatically close the related issue #186 since I don't have anything to further add, if you have any questions, suggestions, or ideas, you can reopen the issue #186 and add your thoughts as a comment.

@surmelienes1 surmelienes1 merged commit 9f49fb0 into master May 16, 2022
@surmelienes1 surmelienes1 deleted the practice-app/feature/get-lesson-events-endpoint-186 branch May 16, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
practice-app:back-end Related to the back-end of the practice app practice-app Related to the practice app project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Practice App: Implementing the GET method for getting lesson events
2 participants