Practice app/frontend/categories page 204 #205
Conversation
There was a problem hiding this comment.
After running the code in my local, I have observed that when entering an invalid category in Add Category field, the category is added as undefined. I think it should show an error and do not add anything to the categories list.
Besides that I think everything looks amazing, good work!
|
I solved the problem and added suggesting feature property to the categories. |
mbatuhancelik
requested review from
bahricanyesil
and removed request for
onurkomurcu
There was a problem hiding this comment.
I reviewed the whole work you did. I fetched and pulled the branch on my local repo. Then, I tested the functionalities. I encountered with the error about two way suggestions (suggesting sport when written sports and vice versa). @mbatuhancelik solved this problem with the latest commit. Currently, I couldn't see anyother problem and the functionality works as expected. I am approving the PR and merging it to the master branch.
As mentioned in #204, frontend page for categories is implemented and ready to be used.