Practice App: Implementing GET Lesson by Name Endpoint #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurkomurcu
added
priority-critical
onurkomurcu
changed the title
8 tasks
8 tasks
egemenatikk
approved these changes
May 18, 2022
There was a problem hiding this comment.
Thank you for your work @onurkomurcu. In your code, we fetch courses with the exact name that is given in query. As we decided to keep our practice-app simple, this implementation is good enough. In our main project we can implement this method as keyword search, maybe.
As I said, I cannot think of anything else to add and I think it is ready to be merged.
onurkomurcu
changed the title
onurkomurcu
added
Status: Completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented get lesson by name endpoint. Issue can be found here: #184. Postman results can be seen from the issue. It is now ready to be reviewed.