Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing the Get Specific Event Details Endpoint #216

Merged
merged 11 commits into from
May 19, 2022
Merged

Implementing the Get Specific Event Details Endpoint #216

merged 11 commits into from
May 19, 2022

Conversation

surmelienes1
Copy link
Contributor

This PR includes the following actions:

  1. Check whether the incoming data is valid
  2. Check whether the event exists
  3. Return an error message if an error occurs in any of the previous steps
  4. Test the endpoint with Postman
  5. Save requests as a collection in Postman
  6. Document the endpoint

Now, the get specific event details endpoint is ready for requests.

This PR closes #215 , other details can also be seen from that issue.

@surmelienes1 surmelienes1 added priority-medium Medium level priority issue status-needreview A review to the issue is needed practice-app Related to the practice app project practice-app:back-end Related to the back-end of the practice app labels May 18, 2022
@surmelienes1 surmelienes1 self-assigned this May 18, 2022
@surmelienes1 surmelienes1 mentioned this pull request May 18, 2022
Closed
7 tasks
@surmelienes1 surmelienes1 requested review from bahricanyesil and egemenatikk and removed request for ezgy and mbatuhancelik May 19, 2022 12:16
egemenatikk
egemenatikk approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@egemenatikk egemenatikk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @surmelienes1. This endpoint looks very nice for getting specific event details, since it also has no conflicts, it is ready to be merged.

@egemenatikk egemenatikk merged commit 32be8f0 into master May 19, 2022
@egemenatikk egemenatikk deleted the practice-app/feature/get-event-details-endpoint-215 branch May 19, 2022 13:23
@surmelienes1 surmelienes1 added Status: Completed Issue is solved and removed status-needreview A review to the issue is needed labels Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egemenatikk egemenatikk egemenatikk approved these changes

@bahricanyesil bahricanyesil Awaiting requested review from bahricanyesil

Assignees

@surmelienes1 surmelienes1

Labels
practice-app:back-end Related to the back-end of the practice app practice-app Related to the practice app project priority-medium Medium level priority issue Status: Completed Issue is solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Practice App: Implementing the GET Method for Getting Specific Event Details
2 participants
@surmelienes1 @egemenatikk