Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Practice app/feature/get enrolled lessons endpoint 275 #276

Merged

Conversation

egemenatikk
Copy link
Contributor

This PR includes the following actions:

  1. Check whether the incoming data is valid or not
  2. Check whether a user with the given user_id exists or not.
  3. Return enrolled lessons array of the user with the given user_id
  4. Return an error message if an error occurs in any of the previous steps
  5. Test the endpoint with Postman
  6. Save requests as a collection in Postman
  7. Document the endpoint

Now, the get enrolled lessons endpoint is ready for requests.

This PR closes #275, other details can also be seen from that issue.

@egemenatikk egemenatikk added feature New feature practice-app Related to the practice app project practice-app:back-end Related to the back-end of the practice app labels May 20, 2022
@egemenatikk egemenatikk requested review from xltvy and surmelienes1 May 20, 2022 09:10
@egemenatikk egemenatikk self-assigned this May 20, 2022
Copy link
Contributor

@surmelienes1 surmelienes1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems very good and complete, thank you @egemenatikk for your valuable contributions.

I will now merge these changes with the master branch and automatically close the related issue #275 since I don't have anything to further add, if you have any questions, suggestions, or ideas, you can reopen the issue #275 and add your thoughts as a comment.

@surmelienes1 surmelienes1 merged commit 380175c into master May 20, 2022
@surmelienes1 surmelienes1 deleted the practice-app/feature/get-enrolled-lessons-endpoint-275 branch May 20, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature practice-app:back-end Related to the back-end of the practice app practice-app Related to the practice app project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Practice App: Implementing GET method for Fetching Enrolled Lessons
2 participants