Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Verification screen network tests #455

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Mobile: Verification screen network tests #455

merged 1 commit into from
Oct 31, 2022

Conversation

egemenatikk
Copy link
Contributor

I added network connection tests to verification. It passed all tests, here is the screenshot:

image

Merging this PR into dev branch closes #454.

@egemenatikk egemenatikk added priority-medium Medium level priority issue status-needreview A review to the issue is needed mobile Mobile related items tests Related to testing labels Oct 31, 2022
@egemenatikk egemenatikk self-assigned this Oct 31, 2022
@egemenatikk egemenatikk changed the base branch from master to dev October 31, 2022 11:44
ezgy
ezgy approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@ezgy ezgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me. The tests pass.

@ezgy ezgy added Status: Completed Issue is solved and removed status-needreview A review to the issue is needed labels Oct 31, 2022
@egemenatikk egemenatikk merged commit 10fc5d3 into dev Oct 31, 2022
@egemenatikk egemenatikk deleted the mobile/verification-screen-network-tests-454 branch October 31, 2022 12:43
@egemenatikk egemenatikk mentioned this pull request Oct 31, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezgy ezgy ezgy approved these changes

@bahricanyesil bahricanyesil Awaiting requested review from bahricanyesil

@onurkomurcu onurkomurcu Awaiting requested review from onurkomurcu

Assignees

@egemenatikk egemenatikk

Labels
mobile Mobile related items priority-medium Medium level priority issue Status: Completed Issue is solved tests Related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile: Writing Network Connection Tests for Verification Screen
2 participants
@egemenatikk @ezgy