Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend: Unit Tests for Categories Page #676

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Frontend: Unit Tests for Categories Page #676

merged 1 commit into from
Dec 7, 2022

Conversation

xltvy
Copy link
Contributor

@xltvy xltvy commented Dec 7, 2022

PR Description:

I have implemented the unit tests regarding the categories page. With this implementation I am testing the general snapshot render, and components in the page.

Notes:

  • The page passes all of the five unit tests implemented.

Routine Check

  • I have fetched and pulled the latest version of the parent branch.
  • This PR does not have any conflicts with the parent branch.

Corresponding Issue

Closes #673

@xltvy xltvy added priority-low Low level priority issue status-needreview A review to the issue is needed front-end Front-end related items tests Related to testing labels Dec 7, 2022
@xltvy xltvy self-assigned this Dec 7, 2022
@xltvy xltvy linked an issue Dec 7, 2022 that may be closed by this pull request
Frontend: Unit Tests for Categories Page #673
Closed
3 tasks
@xltvy xltvy mentioned this pull request Dec 7, 2022
Closed
3 tasks
@surmelienes1 surmelienes1 merged commit 0a2e301 into dev-frontend Dec 7, 2022
@surmelienes1
Copy link
Contributor

Conclusion

Thank you @xltvy for your valuable contributions! I ran the tests you have implemented on my local system, and they all worked as expected.

I have now approved the modifications you have made and merged the commits as we go forward with the implementation.

@surmelienes1 surmelienes1 added Status: Completed Issue is solved and removed status-needreview A review to the issue is needed labels Dec 7, 2022
@bahricanyesil bahricanyesil deleted the dev-frontend-categories-page-unit-tests branch December 17, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gokayyildiz gokayyildiz Awaiting requested review from gokayyildiz

@surmelienes1 surmelienes1 Awaiting requested review from surmelienes1

@Koraytkn Koraytkn Awaiting requested review from Koraytkn

Assignees

@xltvy xltvy

Labels
front-end Front-end related items priority-low Low level priority issue Status: Completed Issue is solved tests Related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend: Unit Tests for Categories Page
2 participants
@xltvy @surmelienes1