Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend] Implementing Discussion Thread Page #323

Closed
2 tasks done
burakmert236 opened this issue Nov 26, 2022 · 4 comments
Closed
2 tasks done

[Frontend] Implementing Discussion Thread Page #323

burakmert236 opened this issue Nov 26, 2022 · 4 comments
Assignees
@burakmert236
Labels
Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Team: Frontend Frontend based work - for frontend team

Comments

@burakmert236
Copy link
Contributor

burakmert236 commented Nov 26, 2022 •
edited
Loading

Description:

Discussion thread page will be implemented. A specific post and its comments must be seen in this page. Also, users will be able to share comments to a post through discussion thread page.

Todo's:

  • Initial version of the page which works with mock data will be implemented.
  • Necessary backend endpoints will be used for the purposes of upvoting/downvoting a post and sharing a comment.

Reviewer: @yavuuzsameet

Task Deadline: 28.11.2022 22:00
Review Deadline: 29.11.2022 12:00
@burakmert236 burakmert236 added Prio: Medium Importance of Issue: Medium Status: In Progress Issue is worked on, currently Team: Frontend Frontend based work - for frontend team labels Nov 26, 2022
@burakmert236 burakmert236 self-assigned this Nov 26, 2022
@burakmert236
Copy link
Contributor Author

I implemented the initial version and push this branch.

@burakmert236
Copy link
Contributor Author

I pushed new commits for backend connection. This version works fine but further debugs might be needed depending restructuralization of endpoints of backend.

@burakmert236 burakmert236 added Status: Need Review Issue work is done, waiting to be reviewed and removed Status: In Progress Issue is worked on, currently labels Nov 29, 2022
@burakmert236 burakmert236 mentioned this issue Nov 29, 2022
Merged
3 tasks
@Keremgunduz7
Copy link
Contributor

Since there will be text in HTML format, maybe you can further check if it is rendered correctly or not.
But overall Looks good to me.
Thanks.

@burakmert236
Copy link
Contributor Author

Thanks for your review, I enabled rendering post and comment strings as HTML and pushed to the same branch. We should also enable this feature in homepage as well.

@burakmert236 burakmert236 added Status: Accepted Issue is reviewed, accepted and removed Status: Need Review Issue work is done, waiting to be reviewed labels Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@burakmert236 burakmert236

Labels
Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Team: Frontend Frontend based work - for frontend team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burakmert236 @Keremgunduz7