Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Practice App: Implementing the API for Rate Post #96

Closed
8 tasks done
oguzhandemirelx opened this issue May 12, 2022 · 2 comments
Closed
8 tasks done

Practice App: Implementing the API for Rate Post #96

oguzhandemirelx opened this issue May 12, 2022 · 2 comments
Assignees
@oguzhandemirelx
Labels
Prio: High Importance of Issue: High Status: Accepted Issue is reviewed, accepted Type: To Do Our tasks are labeled with this label.

Comments

@oguzhandemirelx
Copy link
Contributor

oguzhandemirelx commented May 12, 2022 •
edited
Loading

Description

According to the endpoints that determined by the group in the Meeting 10.2, rate-post functionalities should be implemented.

We have distributed the tasks among 12 group mates and my main responsibility is to implement rate-post endpoint and API.

Together in the Meeting 10.2, as stated in issues #78 and #79, we have decided on the models and pushed them to our GitHub.

Main functionality of the rate-post part of the project is that,

  • Getting number of upvotes and downvotes of a post with a specific ID as the GET part of API
  • Upvoting or downvoting a post with a specific id as the POST part of API

Details of the rate-post API:

  • Check whether the given data is valid or not.
  • Check whether the post with the given post-id exists.
  • Updating and saving posts, or getting posts.
  • Success or Error Response.
  • Documentation.
  • Postman Test.
  • Saving to Postman.
  • Unit tests.

Requests and responses will be documented by using Postman.

Documentation: Postman

Task Deadline: 14.05.2022 17.05.2022 16:00

Review Deadline: 14.05.2022 17.05.2022 20:00

Reviewers: @mehmetemreakbulut @enginoguzhansenol
@oguzhandemirelx oguzhandemirelx self-assigned this May 12, 2022
@oguzhandemirelx oguzhandemirelx added Prio: High Importance of Issue: High Type: To Do Our tasks are labeled with this label. Status: In Progress Issue is worked on, currently labels May 12, 2022
@oguzhandemirelx
Copy link
Contributor Author

Get and Post endpoints, unit tests are done. Documentation prepared. I added documentation link to the issue.

@oguzhandemirelx oguzhandemirelx added Status: Need Review Issue work is done, waiting to be reviewed and removed Status: In Progress Issue is worked on, currently labels May 17, 2022
mehmetemreakbulut added a commit that referenced this issue May 18, 2022
@mehmetemreakbulut
Merge pull request #128 from bounswe/practice-app/feature/rate-post-#96
ab326c8 
Practice app/feature/rate post #96
@mehmetemreakbulut
Copy link
Contributor

Everything looks fine. We can close the issue.

@palahb palahb added Status: Accepted Issue is reviewed, accepted and removed Status: Need Review Issue work is done, waiting to be reviewed labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oguzhandemirelx oguzhandemirelx

Labels
Prio: High Importance of Issue: High Status: Accepted Issue is reviewed, accepted Type: To Do Our tasks are labeled with this label.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oguzhandemirelx @palahb @mehmetemreakbulut