Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-fix/misdirecting post url #123

Merged
merged 4 commits into from
May 16, 2022
Merged

bug-fix/misdirecting post url #123

merged 4 commits into from
May 16, 2022

Conversation

yavuuzsameet
Copy link
Contributor

@yavuuzsameet yavuuzsameet commented May 16, 2022 •
edited
Loading

I changed template names
from:
index.html
base.html
create.html
get.html
notfound.html

to:
post_index.html
post_base.html
post_create.html
post_get.html
post_notfound.html

@yavuuzsameet yavuuzsameet self-assigned this May 16, 2022
@yavuuzsameet yavuuzsameet added Prio: Low Importance of Issue: Low Status: Need Review Issue work is done, waiting to be reviewed labels May 16, 2022
canberkboun9
canberkboun9 approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@canberkboun9 canberkboun9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes in namings should be a solution to our URL routing problem. Conflicts in namings have been resolved. Merging these changes.

@canberkboun9 canberkboun9 merged commit d6e7e52 into master May 16, 2022
@palahb palahb added Status: Accepted Issue is reviewed, accepted and removed Status: Need Review Issue work is done, waiting to be reviewed labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canberkboun9 canberkboun9 canberkboun9 approved these changes

@mehmetemreakbulut mehmetemreakbulut Awaiting requested review from mehmetemreakbulut

Assignees

@yavuuzsameet yavuuzsameet

Labels
Prio: Low Importance of Issue: Low Status: Accepted Issue is reviewed, accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yavuuzsameet @canberkboun9 @palahb