Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some requested enhancements in practice-app/post-info #138

Merged
merged 1 commit into from
May 18, 2022
Merged

Some requested enhancements in practice-app/post-info #138

merged 1 commit into from
May 18, 2022

Conversation

kardelendemiral
Copy link
Contributor

  • Error heading is added for the case where invalid values are entered when updating a post.
  • API used for retrieving covid19 cases is changed since the other one does not work sometimes.
  • Country name that is used for retrieving covid19 cases is made case-insensitive.
  • A little note is added asking user to enter the category id, not the name of it, to the page where the forms exist to avoid any confusion.

Relevant issues: issue #135, issue #137

Reviewers: @Keremgunduz7 , @yavuuzsameet

@kardelendemiral
Some requested enhancements
44a5e33 
- Error heading is added for the case where invalid values are entered when updating a post.
- API used for retrieving covid19 cases is changed since the other one does not work sometimes.
- Country name that is used for retrieving covid19 cases  is made case-insensitive.
- A little note is added asking user to enter the category id, not the name of it, to the page where the forms exist avoid any confusion.
@kardelendemiral kardelendemiral self-assigned this May 18, 2022
@kardelendemiral kardelendemiral added enhancement Prio: Medium Importance of Issue: Medium Status: Need Review Issue work is done, waiting to be reviewed Type: Enhancement New features via code and/or design. and removed enhancement labels May 18, 2022
@kardelendemiral kardelendemiral changed the title Some requested enhancements Some requested enhancements in practice-app/post-info May 18, 2022
This was referenced May 18, 2022
Closed
Closed
yavuuzsameet
yavuuzsameet reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@yavuuzsameet yavuuzsameet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the commits. It's all good. New external API looks more convenient.

@yavuuzsameet yavuuzsameet merged commit 78d0209 into master May 18, 2022
@Keremgunduz7 Keremgunduz7 linked an issue May 18, 2022 that may be closed by this pull request
Practice-App: Implementing API for Post-info - Enhancements #135
Closed
@palahb palahb deleted the practice-app/enhancement/post-info-#135 branch October 22, 2022 22:27
@palahb palahb added Status: Accepted Issue is reviewed, accepted and removed Status: Need Review Issue work is done, waiting to be reviewed labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavuuzsameet yavuuzsameet yavuuzsameet left review comments

@Keremgunduz7 Keremgunduz7 Awaiting requested review from Keremgunduz7

Assignees

@kardelendemiral kardelendemiral

Labels
Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Type: Enhancement New features via code and/or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Practice-App: Implementing API for Post-info - Enhancements
3 participants
@kardelendemiral @yavuuzsameet @palahb