Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend/feature/initial tables #199 #203

Merged
merged 4 commits into from
Oct 23, 2022
Merged

Backend/feature/initial tables #199 #203

merged 4 commits into from
Oct 23, 2022

Conversation

irfanbozkurt
Copy link
Member

  • Added following model classes
    • User
    • Admin
    • MemberInfo
    • Member
    • Category
    • Doctor
    • Report
  • Migrated these models to the database
    • In other words, database tables for these models are created
  • Wrote unit tests for model creations
  • Turned DB password into an environment variable for safety reasons

mehmetemreakbulut
mehmetemreakbulut reviewed Oct 23, 2022
View reviewed changes
Copy link
Contributor

@mehmetemreakbulut mehmetemreakbulut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files were reviewed.
Notes were written on PR

canberkboun9
canberkboun9 requested changes Oct 23, 2022
View reviewed changes
Copy link
Contributor

@canberkboun9 canberkboun9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the time and effort!

  • In the app/backend/backend/models.py file, line 63 should be retval += self.info.lastname
  • line 27, line 28: null=True is the needed change, I think.
  • Added one line comments on the code while reviewing

@irfanbozkurt
Copy link
Member Author

Hey @canberkboun9, thanks for your review!

I fulfilled your requests with this commit.

canberkboun9
canberkboun9 approved these changes Oct 23, 2022
View reviewed changes
Copy link
Contributor

@canberkboun9 canberkboun9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required changes are done. I am unable to see another issue. We can merge this branch with master.

@canberkboun9 canberkboun9 merged commit 4aa5d6a into master Oct 23, 2022
@irfanbozkurt irfanbozkurt mentioned this pull request Oct 23, 2022
Closed
3 tasks
@palahb palahb deleted the backend/feature/initial_tables-#199 branch December 6, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehmetemreakbulut mehmetemreakbulut mehmetemreakbulut left review comments

@canberkboun9 canberkboun9 Awaiting requested review from canberkboun9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irfanbozkurt @canberkboun9 @mehmetemreakbulut