Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] Code Refactor #298

Merged
merged 1 commit into from
Nov 19, 2022
Merged

[Backend] Code Refactor #298

merged 1 commit into from
Nov 19, 2022

Conversation

irfanbozkurt
Copy link
Member

@irfanbozkurt irfanbozkurt mentioned this pull request Nov 19, 2022
Closed
@irfanbozkurt irfanbozkurt added Team: Backend Backend based work - for backend team Code refactor labels Nov 19, 2022
@irfanbozkurt irfanbozkurt self-assigned this Nov 19, 2022
@irfanbozkurt irfanbozkurt changed the title Code Refactor [Backend] Code Refactor Nov 19, 2022
mehmetemreakbulut
mehmetemreakbulut approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@mehmetemreakbulut mehmetemreakbulut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring is not fully done but this PR is partially handling some problems. Reviewed. Well done!

@mehmetemreakbulut
Copy link
Contributor

I reviewed and commented. Well done!

@mehmetemreakbulut mehmetemreakbulut merged commit 3dd5287 into master Nov 19, 2022
@canberkboun9
Copy link
Contributor

I acknowledge the changes although I didn't understand their effects (password test part)

@palahb palahb deleted the backend/feature/refactor-#297 branch December 6, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehmetemreakbulut mehmetemreakbulut mehmetemreakbulut approved these changes

@canberkboun9 canberkboun9 Awaiting requested review from canberkboun9

Assignees

@irfanbozkurt irfanbozkurt

Labels
Code refactor Team: Backend Backend based work - for backend team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irfanbozkurt @mehmetemreakbulut @canberkboun9