Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] Bookmark a Post implementation #463

Merged
merged 3 commits into from
Dec 23, 2022
Merged

[Backend] Bookmark a Post implementation #463

merged 3 commits into from
Dec 23, 2022

Conversation

oguzhandemirelx
Copy link
Contributor

@oguzhandemirelx oguzhandemirelx commented Dec 22, 2022 •
edited
Loading

Description:
We received feedback regarding bookmarking posts and articles in customer milestone 2. A registered user may save a post or article and return to it at any time. So I'll put the following into action.

Todo's:

  • New endpoint for bookmark a post.
  • New endpoint for getting all bookmarked posts.
  • Add unit tests for that endpoints.
  • Change necessary fields on User.

Notes:

  • New endpoint added for bookmark a post: POST forum/post/int:id/bookmark
  • New endpoint added for get all bookmarked posts: GET profile/bookmarked_posts

Reviewer: @mehmetemreakbulut

Task Deadline: 23.12.2022 22:00
Review Deadline: 23.12.2022 22:00

@oguzhandemirelx oguzhandemirelx added Prio: Medium Importance of Issue: Medium Status: Need Review Issue work is done, waiting to be reviewed Team: Backend Backend based work - for backend team labels Dec 22, 2022
@oguzhandemirelx oguzhandemirelx self-assigned this Dec 22, 2022
canberkboun9
canberkboun9 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@canberkboun9 canberkboun9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation! I couldn't find a bug. I approve the PR, but merge can wait until another review?

@canberkboun9
Copy link
Contributor

Tests run correctly, merging it.

@canberkboun9 canberkboun9 merged commit 27a1581 into master Dec 23, 2022
@canberkboun9 canberkboun9 linked an issue Dec 23, 2022 that may be closed by this pull request
[Backend] Bookmark a Post implementation #462
Closed
4 tasks
@canberkboun9 canberkboun9 added Status: Accepted Issue is reviewed, accepted and removed Status: Need Review Issue work is done, waiting to be reviewed labels Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canberkboun9 canberkboun9 canberkboun9 approved these changes

@mehmetemreakbulut mehmetemreakbulut Awaiting requested review from mehmetemreakbulut

Assignees

@oguzhandemirelx oguzhandemirelx

Labels
Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Team: Backend Backend based work - for backend team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Backend] Bookmark a Post implementation
2 participants
@oguzhandemirelx @canberkboun9