Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Practice app/feature/post #83 & #101 #99

Merged
merged 7 commits into from
May 13, 2022
Merged

Practice app/feature/post #83 & #101 #99

merged 7 commits into from
May 13, 2022

Conversation

yavuuzsameet
Copy link
Contributor

@yavuuzsameet yavuuzsameet commented May 12, 2022 •
edited
Loading

Done:

  • External API added.
  • The user interface is added to the app.
  • Error cases are handled.

To do:

  • The testing is the next step.

This merging closes issue #83 and #101.

@yavuuzsameet yavuuzsameet added Prio: Medium Importance of Issue: Medium Status: Need Review Issue work is done, waiting to be reviewed labels May 12, 2022
@yavuuzsameet yavuuzsameet self-assigned this May 12, 2022
@yavuuzsameet yavuuzsameet linked an issue May 12, 2022 that may be closed by this pull request
Practice App: Implementing API for Post #83
Closed
8 tasks
@yavuuzsameet yavuuzsameet linked an issue May 13, 2022 that may be closed by this pull request
Practice-App: Writing all unit tests for Post app #101
Closed
4 tasks
@yavuuzsameet
Copy link
Contributor Author

Issues #101 and #83 are linked with this pull request. Both issues may be closed after the merging.

@yavuuzsameet yavuuzsameet added Prio: High Importance of Issue: High and removed Prio: Medium Importance of Issue: Medium labels May 13, 2022
@mehmetemreakbulut
Copy link
Contributor

Everything looks fine. New features and tests are also implemented succesfully. Merging to master.

@mehmetemreakbulut mehmetemreakbulut merged commit 30a0c2d into master May 13, 2022
@yavuuzsameet yavuuzsameet changed the title Practice app/feature/post #83 Practice app/feature/post #83 & #101 May 14, 2022
@palahb palahb deleted the practice-app/feature/post-#83 branch October 22, 2022 22:24
@palahb palahb added Status: Accepted Issue is reviewed, accepted and removed Status: Need Review Issue work is done, waiting to be reviewed labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canberkboun9 canberkboun9 Awaiting requested review from canberkboun9

@mehmetemreakbulut mehmetemreakbulut Awaiting requested review from mehmetemreakbulut

Assignees

@yavuuzsameet yavuuzsameet

Labels
Prio: High Importance of Issue: High Status: Accepted Issue is reviewed, accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Practice-App: Writing all unit tests for Post app Practice App: Implementing API for Post
3 participants
@yavuuzsameet @mehmetemreakbulut @palahb