Skip to content

Commit

Permalink
Merge pull request #528 from bounswe/user-unit-tests
Browse files Browse the repository at this point in the history 
User Unit Tests
  • Loading branch information
@Pqrq
Pqrq authored Dec 16, 2024
2 parents 2ca54f4 + f6fc727 commit 21fa98c
Show file tree
Hide file tree
Showing 4 changed files with 214 additions and 38 deletions.
15 changes: 0 additions & 15 deletions backend/src/main/java/com/bounswe2024group10/Tradeverse/dto/post/GetPostResponse.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,6 @@ public class GetPostResponse {
private UserResponse author;
private Subforum subforum;

public GetPostResponse(Long id, String title, List<Content> content, String createdBy,
LocalDateTime creationDate, int likeCount, int dislikeCount,
int commentCount, boolean isLikedByUser, boolean isDislikedByUser) {
this.id = id;
this.title = title;
this.content = content;
this.createdBy = createdBy;
this.creationDate = creationDate;
this.likeCount = likeCount;
this.dislikeCount = dislikeCount;
this.commentCount = commentCount;
this.isLikedByUser = isLikedByUser;
this.isDislikedByUser = isDislikedByUser;
}

public GetPostResponse(Long id, String title, List<Content> content, String createdBy,
LocalDateTime creationDate, int likeCount, int dislikeCount,
int commentCount, boolean isLikedByUser, boolean isDislikedByUser, String userPhoto, String authorUserName, Subforum subforum) {
Expand Down
2 changes: 2 additions & 0 deletions backend/src/main/java/com/bounswe2024group10/Tradeverse/repository/PostRepository.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ public interface PostRepository extends JpaRepository<Post, Long> {

List<Post> findTop100ByOrderByCreationDateDesc();

List<Post> findTop100ByCreatedByOrderByCreationDateDesc(String createdBy);

int countByCreatedBy(String createdBy);

int countBySubforumID(Long subforumID);
Expand Down
29 changes: 6 additions & 23 deletions backend/src/main/java/com/bounswe2024group10/Tradeverse/service/UserService.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ public class UserService {
@Autowired
private CommentRepository commentRepository;

@Autowired
private PostService postService;

public GetUserDetailsResponse getUserDetails(String username) {
User user = userRepository.findByUsername(username);
if (user != null) {
Expand Down Expand Up @@ -88,26 +91,6 @@ public SetUserDetailsResponse setUserDetails(SetUserDetailsRequest userDetailsRe
return new SetUserDetailsResponse(true, "User details updated successfully");
}

private GetPostResponse convertToGetPostResponse(Post post, String username) {
int likeCount = likeRepository.countByPostID(post.getId());
int dislikeCount = dislikeRepository.countByPostID(post.getId());
int commentCount = commentRepository.countByPostID(post.getId());
boolean isLikedByUser = username != null && likeRepository.existsByUsernameAndPostID(username, post.getId());
boolean isDislikedByUser = username != null && dislikeRepository.existsByUsernameAndPostID(username, post.getId());
return new GetPostResponse(
post.getId(),
post.getTitle(),
post.getContent(),
post.getCreatedBy(),
post.getCreationDate(),
likeCount,
dislikeCount,
commentCount,
isLikedByUser,
isDislikedByUser
);
}

public GetProfileResponse getProfile(String username, String requesterUsername) {
User user = userRepository.findByUsername(username);
if (user == null) {
Expand All @@ -117,9 +100,9 @@ public GetProfileResponse getProfile(String username, String requesterUsername)
int followerCount = followRepository.countByFollowedUsername(username);
boolean isFollowing = followRepository.findByFollowerUsernameAndFollowedUsername(requesterUsername, username) != null;
List<GetPostResponse> recentPostResponses = new ArrayList<>();
List<Post> recentPosts = postRepository.findTop100ByOrderByCreationDateDesc();
List<Post> recentPosts = postRepository.findTop100ByCreatedByOrderByCreationDateDesc(username);
for (Post post : recentPosts) {
recentPostResponses.add(convertToGetPostResponse(post, requesterUsername));
recentPostResponses.add(postService.convertToGetPostResponse(post, requesterUsername));
}
Map<Long, Integer> postScoreMap = new HashMap<>();
for (Post post : recentPosts) {
Expand All @@ -134,7 +117,7 @@ public GetProfileResponse getProfile(String username, String requesterUsername)
.collect(Collectors.toList());
List<GetPostResponse> popularPostResponses = new ArrayList<>();
for (Post post : sortedPosts) {
popularPostResponses.add(convertToGetPostResponse(post, requesterUsername));
popularPostResponses.add(postService.convertToGetPostResponse(post, requesterUsername));
}
return new GetProfileResponse(user.getUsername(), user.getName(), user.getProfilePhoto(), postCount, followerCount, isFollowing, popularPostResponses, recentPostResponses);
}
Expand Down
206 changes: 206 additions & 0 deletions backend/src/test/java/service/UserServiceUnitTest.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,206 @@
package service;

import java.io.IOException;
import java.util.ArrayList;
import java.util.List;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import static org.mockito.Mockito.when;
import org.mockito.MockitoAnnotations;

import com.bounswe2024group10.Tradeverse.dto.user.GetProfileResponse;
import com.bounswe2024group10.Tradeverse.dto.user.GetUserDetailsResponse;
import com.bounswe2024group10.Tradeverse.dto.user.SetUserDetailsRequest;
import com.bounswe2024group10.Tradeverse.dto.user.SetUserDetailsResponse;
import com.bounswe2024group10.Tradeverse.model.Follow;
import com.bounswe2024group10.Tradeverse.model.Post;
import com.bounswe2024group10.Tradeverse.model.User;
import com.bounswe2024group10.Tradeverse.repository.CommentRepository;
import com.bounswe2024group10.Tradeverse.repository.DislikeRepository;
import com.bounswe2024group10.Tradeverse.repository.FollowRepository;
import com.bounswe2024group10.Tradeverse.repository.LikeRepository;
import com.bounswe2024group10.Tradeverse.repository.PostRepository;
import com.bounswe2024group10.Tradeverse.repository.UserRepository;
import com.bounswe2024group10.Tradeverse.service.PostService;
import com.bounswe2024group10.Tradeverse.service.UserService;

public class UserServiceUnitTest {

@InjectMocks
private UserService userService;

@Mock
private UserRepository userRepository;

@Mock
private PostRepository postRepository;

@Mock
private FollowRepository followRepository;

@Mock
private LikeRepository likeRepository;

@Mock
private DislikeRepository dislikeRepository;

@Mock
private CommentRepository commentRepository;

@Mock
private PostService postService;

@BeforeEach
public void setUp() {
MockitoAnnotations.openMocks(this);
MockitoAnnotations.openMocks(postService);
}

@Test
public void testGetUserDetails_UserExists() {
User user = new User();
user.setUsername("testuser");
user.setEmail("testuser@example.com");
user.setName("Test User");
user.setProfilePhoto("profile.jpg");
user.setTag(0);
user.setBio("This is a bio");
user.setIsAdmin(false);

when(userRepository.findByUsername("testuser")).thenReturn(user);

GetUserDetailsResponse response = userService.getUserDetails("testuser");

assertNotNull(response);
assertEquals("testuser@example.com", response.getEmail());
assertEquals("testuser", response.getUsername());
assertEquals("Test User", response.getName());
assertEquals("profile.jpg", response.getProfilePhoto());
assertEquals(0, response.getTag());
assertEquals("This is a bio", response.getBio());
assertFalse(response.isAdmin());
}

@Test
public void testGetUserDetails_UserDoesNotExist() {
when(userRepository.findByUsername("nonexistentuser")).thenReturn(null);

GetUserDetailsResponse response = userService.getUserDetails("nonexistentuser");

assertNull(response);
}

@Test
public void testSetUserDetails_UserExists() {
User user = new User();
user.setUsername("testuser");
user.setEmail("testuser@example.com");
user.setName("Test User");
user.setProfilePhoto("profile.jpg");
user.setTag(0);
user.setBio("This is a bio");
user.setIsAdmin(false);

SetUserDetailsRequest request = new SetUserDetailsRequest();
request.setEmail("newemail@example.com");
request.setBio("New bio");
request.setTag(1);

when(userRepository.findByUsername("testuser")).thenReturn(user);

SetUserDetailsResponse response = userService.setUserDetails(request, "testuser");

assertNotNull(response);
assertEquals(true, response.getIsSuccessful());
assertEquals("User details updated successfully", response.getMessage());
assertEquals("newemail@example.com", user.getEmail());
assertEquals("New bio", user.getBio());
assertEquals(1, user.getTag());
}

@Test
public void testSetUserDetails_UserDoesNotExist() {
SetUserDetailsRequest request = new SetUserDetailsRequest();
request.setEmail("newemail@example.com");
request.setBio("New bio");
request.setTag(1);

when(userRepository.findByUsername("nonexistentuser")).thenReturn(null);

SetUserDetailsResponse response = userService.setUserDetails(request, "nonexistentuser");

assertNotNull(response);
assertEquals(false, response.getIsSuccessful());
assertEquals("User not found", response.getMessage());
}

@Test
public void testSetUserDetails_Email() throws IOException {
User user = new User();
user.setUsername("testuser");

SetUserDetailsRequest request = new SetUserDetailsRequest();
request.setEmail("testuser@tradeverse.com");

when(userRepository.findByUsername("testuser")).thenReturn(user);

SetUserDetailsResponse response = userService.setUserDetails(request, "testuser");

assertNotNull(response);
assertEquals(true, response.getIsSuccessful());
assertEquals("User details updated successfully", response.getMessage());
assertNotNull(user.getEmail());
}

@Test
public void testGetProfile_UserExists() {
User user = new User();
user.setUsername("testuser");
user.setName("Test User");
user.setProfilePhoto("profile.jpg");

when(userRepository.findByUsername("testuser")).thenReturn(user);
when(postRepository.countByCreatedBy("testuser")).thenReturn(10);
when(followRepository.countByFollowedUsername("testuser")).thenReturn(5);
when(followRepository.findByFollowerUsernameAndFollowedUsername("requester", "testuser")).thenReturn(new Follow());

List<Post> recentPosts = new ArrayList<>();
Post post = new Post();
post.setId(1L);
post.setTitle("Test Post");
recentPosts.add(post);

when(postRepository.findTop100ByCreatedByOrderByCreationDateDesc("testuser")).thenReturn(recentPosts);

GetProfileResponse response = userService.getProfile("testuser", "requester");

assertNotNull(response);
assertEquals("testuser", response.getUsername());
assertEquals("Test User", response.getName());
assertEquals("profile.jpg", response.getProfilePhoto());
assertEquals(10, response.getPostCount());
assertEquals(5, response.getFollowerCount());
assertEquals(true, response.isFollowing());
assertNotNull(response.getRecentPosts());
assertNotNull(response.getPopularPosts());
}

@Test
public void testGetProfile_UserDoesNotExist() {
when(userRepository.findByUsername("nonexistentuser")).thenReturn(null);

GetProfileResponse response = userService.getProfile("nonexistentuser", "requester");

assertNotNull(response);
assertEquals(false, response.isSuccess());
assertEquals("User not found", response.getMessage());
}

}

0 comments on commit 21fa98c

Please sign in to comment.