Extra options for poloidal plots #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also specify in docstring what happens if a dict is passed.
'norm' option allows any matplotlib.colors.Normalize instance to be passed, for general control of the color-scale. For convenience, also adds a 'logscale' option which can be set to True to create a standard log-scale if vmin and vmax are both positive or both negative, and a symmetric log-scale with a linear threshold of min(abs(vmin),abs(vmax))*1.e-5 if vmin and vmax have opposite signs. If a float is passed for 'logscale' and vmin and vmax have opposite signs then the value of 'logscale' is used instead of the default 1.e-5 to set the linear threshold.
|
Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-12-10 19:39:19 UTC |
TomNicholas
requested changes
Dec 10, 2019
|
sorry, gridlines doesn't work at the moment. will debug after the meeting |
When setting torodial coordinates, a 'psi_poloidal' coordinate is added, but the x-dimension is not renamed (as psixy is a 2d array, although its values only vary in x). Therefore 'bout_xdim' should be 'x' (the name of the dimension), not 'psi_poloidal'.
johnomotani
force-pushed
the
extra-poloidal-plot-options
branch
from
7fa6411 to
0f4f7b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 45.15% 43.73% -1.43%
==========================================
Files 8 8
Lines 795 862 +67
Branches 152 177 +25
==========================================
+ Hits 359 377 +18
- Misses 380 429 +49
Partials 56 56
Continue to review full report at Codecov.
|
TomNicholas
approved these changes
Dec 10, 2019
xbout/plotting/plotfuncs.py
Outdated
| # Small regions around X-point do not have segments in x- or y-directions, | ||
| # so skip | ||
| continue | ||
| if 'x' in gridlines and gridlines['x'] is not None: |
There was a problem hiding this comment.
You can just do if gridlines.get('x'): if you want, the default return value of .get() if the key isn't found is None.
johnomotani
pushed a commit
that referenced
this pull request
Dec 11, 2019
Extra options for poloidal plots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out 2d-plot changes from #38.