Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

animate_list() method to animate multiple plots at once. #73

Merged
merged 21 commits into from
Dec 10, 2019
Merged

animate_list() method to animate multiple plots at once. #73

merged 21 commits into from
Dec 10, 2019

Conversation

johnomotani
Copy link
Collaborator

Split out from #38. Should be merged after #72.

Replaces #38.

@johnomotani
Method to make multiple animations in one figure
64b91c2
@johnomotani
Implement option to use a color-scale symmetric around 0 in animate_list
8f96bce
@johnomotani
Raise exception instead of using 'assert'
5cae064
@johnomotani
Use animate_pcolormesh in animate_list
8008082
@johnomotani
Support for poloidal plots in animate_list
ac6a6fa
@johnomotani
Import animate_poloidal to fix poloidal_plots option of animate_list
933ef28
@johnomotani
Allow variable names as well as BoutDataArrays in animate_list variables
9f591b0
@johnomotani
Fix appending of blocks when using animate_poloidal in animate_list
03e45b3
@johnomotani
subplots_adjust option for animate_list
d782944
@johnomotani
Allow per-variable vmin and vmax arguments to animate_list
1820639
@johnomotani
Implement logscale option for animate_list
3d533ff
@johnomotani
Document all arguments of animate_list()
cbc2819
@johnomotani
Allow logscale to be passed as a list to animate_list
582d796 
Allows logscale to be passed per-variable.
@johnomotani
Allow poloidal_plot to be passed per variable to animate_list
6a8ff45
@johnomotani
Tests for animate_list
269d705
@johnomotani
Simplify checking for sequences in arguments of animate_list
70f3ac6
@johnomotani
Rename 'this' -> 'subplot_args'
8da3345
@johnomotani
Rename animations->animation in animate_list tests
ba32906 
Returned object is a single animatplot 'animation' with multiple blocks,
not a list of things.
@johnomotani
Check fps was actually set it test_animate_list_fps
3d733de
@pep8speaks
Copy link

pep8speaks commented Dec 10, 2019 •
edited
Loading

Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-10 23:32:43 UTC

@codecov-io
Copy link

codecov-io commented Dec 10, 2019 •
edited
Loading

Codecov Report

Merging #73 into master will decrease coverage by 0.66%.
The diff coverage is 35.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   45.15%   44.49%   -0.67%     
==========================================
  Files           8        8              
  Lines         795      971     +176     
  Branches      152      200      +48     
==========================================
+ Hits          359      432      +73     
- Misses        380      481     +101     
- Partials       56       58       +2
Impacted Files Coverage Δ
xbout/plotting/utils.py 6.91% <11.53%> (+1.99%) ⬆️
xbout/plotting/animate.py 43.93% <24.61%> (-10.94%) ⬇️
xbout/plotting/plotfuncs.py 7.47% <5.71%> (-1.86%) ⬇️
xbout/boutdataarray.py 62.96% <52.94%> (-8.47%) ⬇️
xbout/boutdataset.py 63.7% <81.66%> (+16.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010274a...308c568. Read the comment docs.

@johnomotani johnomotani mentioned this pull request Dec 10, 2019
Closed
@TomNicholas TomNicholas mentioned this pull request Dec 10, 2019
Merged
@rdoyle45 rdoyle45 merged commit 1c13167 into master Dec 10, 2019
@johnomotani johnomotani deleted the animate_list_method branch December 10, 2019 23:39
@johnomotani johnomotani restored the animate_list_method branch December 10, 2019 23:39
@johnomotani johnomotani deleted the animate_list_method branch December 10, 2019 23:40
johnomotani pushed a commit that referenced this pull request Dec 11, 2019
@rdoyle45
Merge pull request #73 from boutproject/animate_list_method
e25b81c 
animate_list() method to animate multiple plots at once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdoyle45 rdoyle45 rdoyle45 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnomotani @pep8speaks @codecov-io @rdoyle45