Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unnecessary code from the diff command #1041

Merged
merged 2 commits into from
Oct 9, 2023
Merged

fix: Remove unnecessary code from the diff command #1041

merged 2 commits into from
Oct 9, 2023

Conversation

theofidry
Copy link
Member

  • Restarting the process is no longer needed within the diff command as extracting the PHAR is done in a separate process.
  • Catching the exception is no longer necessary or desired since any failure will throw a comprehensive error.

@theofidry
fix: Remove unnecessary code from the diff command
892e057 
- Restarting the process is no longer needed within the diff command as
  extracting the PHAR is done in a separate process.
- Catching the exception is no longer necessary or desired since any
  failure will throw a comprehensive error.
@theofidry
fix
c13c88c
@theofidry theofidry merged commit d65001c into box-project:main Oct 9, 2023
19 checks passed
@theofidry theofidry deleted the refactor/diff-cmd branch October 9, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theofidry