Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an internal option to the extract command #975

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

theofidry
Copy link
Member

Introduce the option --internal to the extract command. There is a number of changes with the introduction of this option:

  • Instead of basing the default value to the question of whether the target dir should be deleted or not, it is now done based in this flag
  • When this flag is passed, the error thrown when creating the PHAR is swallowed and its message written to the STDERR. This will allow to retrieve it in Pharaoh when executing it without having the whole stack trace.

Introduce the option `--internal` to the extract command. There is a
number of changes with the introduction of this option:

- Instead of basing the default value to the question of whether the
  target dir should be deleted or not, it is now done based in this flag
- When this flag is passed, the error thrown when creating the PHAR is
  swallowed and its message written to the STDERR. This will allow to
retrieve it in Pharaoh when executing it without having the whole stack
trace.
@theofidry theofidry merged commit 99dabd9 into box-project:main Apr 1, 2023
@theofidry theofidry deleted the refactor/extract-internal branch April 1, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant