Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alerts and share sheets for iPad #92

Merged
merged 6 commits into from
Feb 26, 2020
Merged

Fix alerts and share sheets for iPad #92

merged 6 commits into from
Feb 26, 2020

Conversation

sujaygarlanka
Copy link
Contributor

@sujaygarlanka sujaygarlanka commented Feb 26, 2020 •
edited
Loading

Goals ⚽

  • Fix error that arises when an alert is shown on the iPad
  • Fix error that arises when a share sheet is shown on the iPad

Implementation Details 🚧

  • Both the share sheet (UIActivityViewController) and alerts (UIAlertController) require anchor points for the iPad that can either be a button or the view itself. Both items are now anchored to the view. Also, their arrow directions are set to none, so they will not try to anchor to a button and throw an error.

Testing Details 🔍

  • Manual testing

PJSimon
PJSimon previously approved these changes Feb 26, 2020
View reviewed changes
PJSimon
PJSimon reviewed Feb 26, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sujaygarlanka @PJSimon
Update CHANGELOG.md
f7d150e 
Co-Authored-By: Patrick Simon <patrick@box.com>
@sujaygarlanka sujaygarlanka merged commit 5aa8c25 into master Feb 26, 2020
@sujaygarlanka sujaygarlanka deleted the activity-view-error branch February 26, 2020 00:31
@sujaygarlanka sujaygarlanka changed the title Fixed alerts and share sheets for iPad Fix alerts and share sheets for iPad Feb 26, 2020
@sujaygarlanka sujaygarlanka changed the title Fix alerts and share sheets for iPad Fixed alerts and share sheets for iPad Feb 26, 2020
sujaygarlanka added a commit that referenced this pull request Feb 26, 2020
@sujaygarlanka
Fix alerts and share sheets for iPad (#92)
be1da7d
@sujaygarlanka sujaygarlanka changed the title Fixed alerts and share sheets for iPad Fix alerts and share sheets for iPad Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJSimon PJSimon PJSimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sujaygarlanka @PJSimon