Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where invalid links in a PDF crash the SDK #93

Merged
merged 12 commits into from
Apr 21, 2020
Merged

Conversation

sujaygarlanka
Copy link
Contributor

@sujaygarlanka sujaygarlanka commented Apr 3, 2020

Goals ⚽

  • Fix a bug where invalid links in a PDF are crashing the app when clicked
  • Open links with schemes other than http and https like mailto, tel, sms, etc. in the appropriate apps

Implementation Details 🚧

  • Only links with http or https schemes can be opened by the browser. We check if the URL has one of these schemes, then we open it if it does. This prevents the browser from opening an invalid link and crashing the app.
  • If a link has another scheme like mailto or facetime, we open it in the appropriate app
  • If a link has no scheme, we append https and open it in the browser

Testing Details 🔍

  • Manual testing

@PJSimon PJSimon merged commit 9d04f25 into master Apr 21, 2020
@PJSimon PJSimon deleted the fix-pdf-links branch April 21, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants