feat(content-uploader): add onSelection callback (#3839) #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: gregorywong@box.com <gregorywong@box.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Lukortech
reviewed
Jan 14, 2025
| @@ -42,7 +45,16 @@ const UploadInput = ({ | |||
| data-testid="upload-input" | |||
| directory={isFolderUpload ? '' : undefined} | |||
| multiple={isMultiple} | |||
| onChange={onChange} | |||
| onChange={(event: React.ChangeEvent<HTMLInputElement>) => { | |||
There was a problem hiding this comment.
That comes handy when trying to upload files and their size exceeded 50mb (5010001000 as I figured Box doesn't like 5010241024 too much ;)).
Currnetly I handled it by observing classList string and reacting to the change after the onBeforeUpload fired and contentExplorer changed it's button classes etc.
| if (onSelection && files) { | ||
| const shouldContinue = onSelection(files); | ||
| if (!shouldContinue) { | ||
| return; |
There was a problem hiding this comment.
Is there a way to clear out the file list other than doing files = ''?
I know there's clearCache for remote but it'd be helpful to be able to reset the form other than clicking cancel.
Lukortech
added a commit
to Lukortech/developer.box.com
that referenced
this pull request
Jan 14, 2025
I've found some information scattered around the web about this UI element but the documentation doesn't mention this event and even more intruiguing is that it doesn't really work as I would expect it to. I should be able to validate files (like exceeded size, fileType) before even allowing user to click "upload" button. That's not the case and I've already got davin to write some code: box/box-ui-elements#3841
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an
onSelectioncallback to the ContentUploader component to allow developers to control file selection before upload begins. This implements the suggestion from issue #3839.Changes
onSelectionprop to ContentUploader componentUsage
Testing
Link to Devin run: https://app.devin.ai/sessions/acbecd8da4154ad8aba8d8d81d7bd661