Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(boxai-sidebar): Bump box-ai-content-answers #3856

Merged
merged 5 commits into from
Jan 23, 2025
Merged

feat(boxai-sidebar): Bump box-ai-content-answers #3856

merged 5 commits into from
Jan 23, 2025

Conversation

DanilaRubleuski
Copy link
Contributor

@DanilaRubleuski DanilaRubleuski commented Jan 17, 2025 •
edited
Loading

Bumping box-ai-content-answers package to @0.79.3 version, in order to show Ask tooltip on dedicated button

@DanilaRubleuski DanilaRubleuski requested a review from a team as a code owner January 17, 2025 13:55
jankowiakdawid
jankowiakdawid previously approved these changes Jan 17, 2025
View reviewed changes
greg-in-a-box
greg-in-a-box requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@greg-in-a-box greg-in-a-box left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks likes its complaining that a dependencies that was added to box-ai-content-answers is missing

@DanilaRubleuski DanilaRubleuski requested a review from a team as a code owner January 21, 2025 14:41
@greg-in-a-box
Copy link
Contributor

does @box/item-icon have any translations inside of it?

greg-in-a-box
greg-in-a-box requested changes Jan 21, 2025
View reviewed changes
package.json Outdated Show resolved Hide resolved
@DanilaRubleuski
Copy link
Contributor Author

DanilaRubleuski commented Jan 21, 2025 •
edited by greg-in-a-box
Loading

does @box/item-icon have any translations inside of it?

I see that all the translation files are empty in @box/item-icon package @greg-in-a-box

@greg-in-a-box
Copy link
Contributor

does @box/item-icon have any translations inside of it?

I see that all the translation files are empty in @box/item-icon package @greg-in-a-box

i would update the i18n configuration to include this package just in case one day someone does add in messages

@DanilaRubleuski DanilaRubleuski force-pushed the box-ai-content-answers-bump branch from 480477d to 6a856a4 Compare January 22, 2025 18:31
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot merged commit fbe87d4 into box:master Jan 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-in-a-box greg-in-a-box greg-in-a-box approved these changes

@tjuanitas tjuanitas tjuanitas approved these changes

@kkuliczkowski-box kkuliczkowski-box kkuliczkowski-box left review comments

@jankowiakdawid jankowiakdawid jankowiakdawid left review comments

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DanilaRubleuski @greg-in-a-box @tjuanitas @jankowiakdawid @kkuliczkowski-box