Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade react/react-dom to v16.7 #761

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

frogzsj
Copy link
Contributor

@frogzsj frogzsj commented Jan 10, 2019

BREAKING CHANGE: because it changes min requirements

@frogzsj frogzsj requested a review from a team as a code owner January 10, 2019 20:50
@boxcla
Copy link

boxcla commented Jan 10, 2019

Hi @frogzsj, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla

Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

@frogzsj
Copy link
Contributor Author

frogzsj commented Jan 10, 2019

CLA signed

@priyajeet
Copy link
Contributor

priyajeet commented Jan 10, 2019

@frogzsj frogzsj force-pushed the upgrade-react-v16.7 branch 2 times, most recently from cda5d05 to 226163f Compare January 10, 2019 21:31
jstoffan
jstoffan previously approved these changes Jan 14, 2019
Copy link
Contributor

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all Elements via /test and didn't see any issues.

priyajeet
priyajeet previously approved these changes Jan 14, 2019
BREAKING CHANGE: because it changes min requirements
@jstoffan jstoffan merged commit 918f0b2 into box:master Jan 14, 2019
@priyajeet
Copy link
Contributor

🎉 This PR is included in version 9.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

j3tan added a commit to j3tan/box-ui-elements that referenced this pull request May 2, 2019
BREAKING CHANGE: peerDep React requirement have been bumped higher
j3tan added a commit to j3tan/box-ui-elements that referenced this pull request May 3, 2019
BREAKING CHANGE: peerDep React requirement have been bumped higher
j3tan added a commit that referenced this pull request May 7, 2019
…1171)

* refactor: upgrade react and react-dom to v16.8 (#761)

BREAKING CHANGE: peerDep React requirement have been bumped higher

* refactor(avatar): Refactor Avatar to use hooks

* fix(test): Fixed various test issues, downgraded enzyme back to 3.8.0

* fix(avatar): remove redundant check
@frogzsj frogzsj deleted the upgrade-react-v16.7 branch November 19, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants