Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShift support #17

Open
ksurent opened this issue Jun 12, 2017 · 4 comments
Open

OpenShift support #17

ksurent opened this issue Jun 12, 2017 · 4 comments

Comments

@ksurent
Copy link

ksurent commented Jun 12, 2017

Hi,

what do you think of extending the tool to include OpenShift support? I think it'd be fairly straightforward:

  • make the kubectl binary path configurable
  • maybe adjust client/server version checking code
  • add new demo deployment manifests
  • adjust documentation

Am I missing anything?

@jjqquu
Copy link

jjqquu commented Jan 17, 2018

you may take a look at my prototype of supporting openshift. The s2i part could be ignored if you're not interested.

https://github.com/qujinping/kube-applier

@goober
Copy link

goober commented Jan 26, 2018

@jjqquu are you planning to create a pull request against the main repository anytime soon? I am interested in trying it out and help you with testing

@jjqquu
Copy link

jjqquu commented Feb 2, 2018

@goober, sorry, i have no plan to create a PR right now, because I'm in the middle of something

Good news is my prototype had been verified and it works. So you can use it.

@gregory-lyons
Copy link
Contributor

I am happy to take a look at a PR and am not opposed to adding OpenShift support. Just as a general comment though, I would prefer that adding support for OpenShift does not create a significant additional burden of configuration for those not using OpenShift.

brengarajalu pushed a commit to brengarajalu/kube-applier that referenced this issue Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants