Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing contact names #140

Closed
georgkrause opened this issue Mar 1, 2022 · 2 comments · Fixed by #146
Closed

missing contact names #140

georgkrause opened this issue Mar 1, 2022 · 2 comments · Fixed by #146

Comments

@georgkrause
Copy link

Gurk works pretty well for me, thanks for the amazing work! <3

One thing which bugs me is, that gurk does not show any contact names. Only groups have names. I see your screenshot in the readme and it seems to be intended to show the usernames. Am I doing something wrong? Can I fix it? Can I provide some information to allow you to debug this?

Let me know, keep coding!
@boxdot
Copy link
Owner

boxdot commented Mar 7, 2022

Thanks for you report. I am looking into it.

boxdot added a commit that referenced this issue Mar 11, 2022
@boxdot
Sync contacts
049ca91 
Now we resolve user names from the synced address book, if possible.
We fallback to the profile name, if contact is not in the address
book. And eventually to contacts phone number, if profile retrieval
failed.

The contacts are synced on start-up of the app, however max one time
per hour.

Resolved #140
@boxdot boxdot mentioned this issue Mar 11, 2022
Merged
boxdot added a commit that referenced this issue Mar 11, 2022
@boxdot
Sync contacts
d57c35e 
Now we resolve user names from the synced address book, if possible.
We fallback to the profile name, if contact is not in the address
book. And eventually to contacts phone number, if profile retrieval
failed.

The contacts are synced on start-up of the app, however max one time
per hour.

Resolves #140
boxdot added a commit that referenced this issue Mar 11, 2022
@boxdot
Sync contacts
807e4fa 
Now we resolve user names from the synced address book, if possible.
We fallback to the profile name, if contact is not in the address
book. And eventually to contacts phone number, if profile retrieval
failed.

The contacts are synced on start-up of the app, however max one time
per hour.

Resolves #140
boxdot added a commit that referenced this issue May 12, 2022
@boxdot
Sync contacts (#146)
51d34ad 
Now we resolve user names from the synced address book, if possible.
We fallback to the profile name, if contact is not in the address
book. And eventually to contacts phone number, if profile retrieval
failed.

The contacts are synced on start-up of the app, however max one time
per hour.

Resolves #140
@georgkrause
Copy link
Author

@boxdot Thank you a lot for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync contacts boxdot/gurk-rs
2 participants
@georgkrause @boxdot