Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple instances of gurk causes Signal to become de-linked #261

Closed
josephkerkhof opened this issue Dec 27, 2023 · 5 comments · Fixed by whisperfish/presage#228 or #262
Closed

Multiple instances of gurk causes Signal to become de-linked #261

josephkerkhof opened this issue Dec 27, 2023 · 5 comments · Fixed by whisperfish/presage#228 or #262

Comments

@josephkerkhof
Copy link

Opening multiple instances of gurk causes the Signal authentication to become corrupt.

Steps to reproduce:

  1. Open gurk with an already linked account.
  2. Open another instance of gurk. Observe that gurk is displaying a QR code which is prompting you to link your Signal account.
  3. Close all instances of gurk.
  4. Open gurk. Observe that your old connection with signal is now lost.
@gferon
Copy link
Collaborator

gferon commented Dec 28, 2023

Interesting, I'd expect the opening of the sled DB to fail immediately 🤔

@josephkerkhof
Copy link
Author

I'd be happy to help contribute to a PR resolve this. I was looking at the source code for this and I think it has something to do with this code.

I'm a total n00b at rust tho, but willing to learn!

@boxdot
Copy link
Owner

boxdot commented Dec 31, 2023

@josephkerkhof Thanks for investigating. I followed this code path deeper. It looks like the migration in presage can't open the sled db, fails and drops the current db. That's why relinking happens.

@gferon WDYT?

@gferon
Copy link
Collaborator

gferon commented Dec 31, 2023

Definitely a bug, I can fix it.

@gferon
Copy link
Collaborator

gferon commented Jan 4, 2024

Should be fixed in whisperfish/presage#228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants