-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and isolate message receipts #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thank you. -- I have some comments.
for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I just have the last two comments about the entry api, and then we can merge.
Thank you! Awesome work. |
This PR should both :
ReceiptMessage
s.ReceiptEvent
s that can be created anywhere in the client and they are handled in a separate structure, stored in a set (idea from @boxdot). At regular interval (default 1 per s.; this rate can safely be increased), an event, if any, is sent.Technical clarification : the events are sent grouped by
Uuid
and whether they areDelivered
orRead
, so the number of waiting events cannot exceed2 * (number of active conversations)
.Shortcomings :