Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cursor tracking and multiline input navigation #131

Merged
merged 7 commits into from
Feb 3, 2022
Merged

Conversation

boxdot
Copy link
Owner

@boxdot boxdot commented Feb 1, 2022

Cursor tracks a byte position in a text, and additionally a column
and line. It implements navigation of left/right,line up/down,
beginning/end of a line, and basic word operation. Also it supports
unicode and characters of width > 1.

Message input now supports switching between the single line and
multi-line modes via Alt+Enter. Previously, Alt+Enter inserted a new
line. Having a special mode for multi-line is more powerful, since it
allows navigation between lines with the same shortcuts as navigation
in channels and messages. And it allows pasting multi-line text.

CI is switched to use the stable aarch64 rustc compiler. Nightly was
required due to signal-client using the armv8 feature in aes which
was only available on nightly.

Fixes #129

Cursor tracks a byte position in a text, and additionally a column
and line. It implements navigation of left/right,line up/down,
beginning/end of a line, and basic word operation. Also it supports
unicode and characters of width > 1.

Message input now supports switching between the single line and
multi-line modes via Alt+Enter. Previously, Alt+Enter inserted a new
line. Having a special mode for multi-line is more powerful, since it
allows navigation between lines with the same shortcuts as navigation
in channels and messages. And it allows pasting multi-line text.
@boxdot boxdot mentioned this pull request Feb 2, 2022
@cs-t1
Copy link
Contributor

cs-t1 commented Feb 2, 2022

Wow that's nice. I'm testing this branch.

I catched a small bug: pressing enter while in search mode does add a newline in the message edition box. I think that's probably not intended.

EDIT: this only happens in multiline mode ofc.

@cs-t1
Copy link
Contributor

cs-t1 commented Feb 2, 2022

Also maybe we should mention in the keybindings cheatsheet that the enter, when input box empty shortcut for opening a URL only works in single-line mode

@boxdot
Copy link
Owner Author

boxdot commented Feb 3, 2022

@Sup3Legacy Thanks for your feedback. Fixed.

@cs-t1
Copy link
Contributor

cs-t1 commented Feb 3, 2022

This new interface is really a nice experience. Maybe you can also refine the search mechanism if you see any change you'd like to make.

@boxdot boxdot enabled auto-merge (squash) February 3, 2022 22:13
@boxdot boxdot merged commit 6c803ee into master Feb 3, 2022
@boxdot boxdot deleted the boxdot/cursor branch June 18, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: infinite loop while skkiping words on input box
2 participants