New visual style for receipts #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show ○ (sent), ◉ (received), ● (delivered) unicode icons next to own messages. This can be disabled by adding `show_receipts = false` to the config file. Also optimize the receipts handling code.
boxdot
force-pushed
the
boxdot/notifications-style
branch
from
8f732f2 to
0abbec5
Compare
|
Now that's a nice slick UI! Also the optimization was probably well deserved |
|
I just noticed the internal names for the different message delivery status have been mismatched, it's supposed to be |
|
Just thought that we assume in the receipt handling code that messages are stored in order of increasing timestamp even though this might not be the case on some occasions (because the timestamp is set by the sender, there is some jitter). This means we might not handle receipts correctly in these edge cases. |
|
Very good observation. Either we need to sort then and maintain the order, or maintain a lookup table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show ○ (sent), ◉ (received), ● (delivered) unicode icons next to own
messages. This can be disabled by adding
show_receipts = falsetothe config file.
Also optimize the receipts handling code.