Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add husky precommit hook and prettier #32

Merged
merged 2 commits into from
Jan 17, 2023
Merged

feat: add husky precommit hook and prettier #32

merged 2 commits into from
Jan 17, 2023

Conversation

evavirseda
Copy link
Member

Fixes #26

Changes

  • add husky and prettier
  • format project

Checks

  • Have you catchup your branch with the latest state in base?
  • Have you lint your code locally prior to submission?
  • Have you reviewed your proposed changes and removed debris?
  • Have you successfully ran due tests with your changes?

@evavirseda evavirseda mentioned this pull request Jan 17, 2023
Merged
4 tasks
aspnxdd
aspnxdd approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@aspnxdd aspnxdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested the precommit hook locally and works 🔥

@aspnxdd aspnxdd merged commit 7ef66f9 into main Jan 17, 2023
@aspnxdd aspnxdd deleted the feat/add-precommit-hook branch January 17, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspnxdd aspnxdd aspnxdd approved these changes

@begonaalvarezd begonaalvarezd Awaiting requested review from begonaalvarezd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filler Task]: Add husky precommit hook
2 participants
@evavirseda @aspnxdd