Audit Logs for Admin Portal #1105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niwsa
reviewed
May 3, 2023
Done. Now it will display a message if Retraced is not configured properly. |
niwsa
reviewed
May 4, 2023
| @@ -123,6 +123,11 @@ export const Sidebar = ({ isOpen, setIsOpen }: SidebarProps) => { | |||
| text: 'Single Sign-On', | |||
| active: asPath.includes('/admin/settings/sso-connection'), | |||
| }, | |||
| { | |||
| href: '/admin/settings/audit-log', | |||
| text: 'Audit Log', | |||
There was a problem hiding this comment.
Maybe the title can be 'Audit Logs (For Admin Portal)' to distinguish it from the existing 'Audit logs' tab
There was a problem hiding this comment.
/settings/* is Admin Portal related hence it is obvious that it is for Admin Portal I think. Audit Logs (For Admin Portal) can be a bit long for a tab name, doesn't fit in a single line.
niwsa
reviewed
May 4, 2023
niwsa
reviewed
May 4, 2023
# Conflicts: # package-lock.json # pages/api/v1/connections/index.ts # pages/api/v1/saml/config.ts
|
Closed in favour of #1972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #651
Type of change
How should this be tested?
Checklist: