refactor(tier4_control_rviz_plugin): apply clang-tidy (tier4#1597)

* refactor(tier4_control_rviz_plugin): apply clang-tidy * revert: readability-identifier-naming Signed-off-by: h-ohta <hiroki.ota@tier4.jp> Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali · Oct 3, 2022 · 62eabb3 · 62eabb3
1 parent aa85108
commit 62eabb3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/common/tier4_control_rviz_plugin/src/tools/manual_controller.cpp b/common/tier4_control_rviz_plugin/src/tools/manual_controller.cpp
@@ -102,7 +102,7 @@ ManualController::ManualController(QWidget * parent) : rviz_common::Panel(parent
   v_layout->addLayout(cruise_velocity_layout);
   setLayout(v_layout);
 
-  QTimer * timer = new QTimer(this);
+  auto * timer = new QTimer(this);
   connect(timer, &QTimer::timeout, this, &ManualController::update);
   timer->start(30);
 }
@@ -268,7 +268,7 @@ void ManualController::onClickEnableButton()
       return;
     }
     client_engage_->async_send_request(
-      req, [this]([[maybe_unused]] rclcpp::Client<EngageSrv>::SharedFuture result) {});
+      req, []([[maybe_unused]] rclcpp::Client<EngageSrv>::SharedFuture result) {});
   }
 }
 

diff --git a/common/tier4_control_rviz_plugin/src/tools/manual_controller.hpp b/common/tier4_control_rviz_plugin/src/tools/manual_controller.hpp
@@ -54,7 +54,7 @@ class ManualController : public rviz_common::Panel
   explicit ManualController(QWidget * parent = nullptr);
   void onInitialize() override;
 
-public Q_SLOTS:
+public Q_SLOTS:  // NOLINT for Qt
   void onClickCruiseVelocity();
   void onClickEnableButton();
   void onManualSteering();
@@ -95,7 +95,7 @@ public Q_SLOTS:
   QDial * steering_slider_ptr_;
   QLabel * steering_angle_ptr_;
 
-  bool current_engage_;
+  bool current_engage_{false};
 };
 
 }  // namespace rviz_plugins