Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify output of fileSummarizeShort() and fileSummarizeLong() and simple language support for number formats #300

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

fschaefer
Copy link
Contributor

Basically this fixes a inconsistency in fileSummarizeShort() and fileSummarizeLong() and adds i18n support for number formats i.e. decimal and thousands separators.

$>./scc
...
Estimated Cost to Develop (organic) $667,319
Estimated Schedule Effort (organic) 11.79 months
Estimated People Required (organic) 5.03

$>LANG=de ./scc
...
Estimated Cost to Develop (organic) $667.319
Estimated Schedule Effort (organic) 11,79 months
Estimated People Required (organic) 5,03

At the moment I'm thinking about refactoring the COCOMO output to SLOCCount's output format, i.e. writing out the formula for calculating the values for better understanding of the printed values. But I'm unsure if this is something for a PR or a private branch...

fileSummarizeLong() is just the wider version of fileSummarizeShort() (-w flag) that additionally prints "Complexity/Lines".
The COCOMO ouput was a bit out of sync through copy & paste.
@boyter
Copy link
Owner

boyter commented Nov 2, 2021

Id say an option for COCOMO would be better allowing it to flip into SLOCCount's output would be better. IE opt in to it.

Looking though this now.

@boyter boyter merged commit ec8912f into boyter:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants