Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blade Template language support #327

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Add Blade Template language support #327

merged 1 commit into from
Mar 29, 2022

Conversation

nathanaelhoun
Copy link
Contributor

Language documentation : https://laravel.com/docs/blade.

@boyter
Copy link
Owner

boyter commented Mar 24, 2022

Now this is something I had not anticipated. Having two languages, where they almost share the same extension .php but with one being .blade.php

I haven't checked yet, but I suspect this works randomly due to Go's map ordering and which one it hits first when processing.

Im going to have to try this out a bit to ensure it works as expected. I suspect it might need to have the keywords values populated to indicate that this is a blade file to ensure its correct. Ill add some tests to determine how likely this is first.

Thanks for the PR and including the language documentation.

@boyter boyter added the enhancement New feature or request label Mar 24, 2022
@boyter boyter merged commit e53bd90 into boyter:master Mar 29, 2022
@nathanaelhoun nathanaelhoun deleted the add-blade-template-language-support branch March 30, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants