Make OpenMetrics output spec compliant #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusg
force-pushed
the
fix-openmetrics
branch
3 times, most recently
from
b7df7c3
to
de9bc7a
Compare
The current output is valid for Prometheus, but not the derived OpenMetrics format: - Spaces between comma-separated labels are not permitted - The exposition must end with a `# EOF` line - UNIT must be a suffix of the metric name, i.e. `scc_code` cannot have the unit `lines` Additionally: - Complexity is not measured in 'lines' For reference, see: https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md
linusg
force-pushed
the
fix-openmetrics
branch
from
de9bc7a
to
0f3375b
Compare
|
Sorry lost track of this. Merging in, since I am presuming it to be correct :) OpenMetrics is not something I am overly familiar with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current output is valid for Prometheus, but not the derived OpenMetrics format:
# EOFlinescc_codecannot have the unitlinesAdditionally:
For reference, see:
https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md
I chose to remove the invalid
UNITs instead of renaming them to 1) not break people's monitoring and dashboards and 2) keep things consistent with the internal names, and names used in other output formats.Ref #307, cc @jan-guenter