Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the Gopkg.toml and Gopkg.lock files leftover from golang/dep #430

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

steverusso
Copy link
Contributor

It seems these might have been overlooked when converting to Go modules about four years ago, or maybe they were left in for golang/dep users to have time to move to Go modules.

In any case, as long as I'm not missing something, golang/dep has been archived for over three years now, so it's probably safe to remove them?

@boyter
Copy link
Owner

boyter commented Feb 18, 2024

Weird... I thought I had removed them ages ago. Nevermind! Cheers for the PR!.

@boyter boyter merged commit aff331e into boyter:master Feb 18, 2024
1 check passed
@steverusso
Copy link
Contributor Author

@boyter cheers for this awesome project! 🙂

Just a quick followup question: is the vendor directory itself currently used at all? Or are you just keeping it around as a way to reliably have access to those external dependencies?

@boyter
Copy link
Owner

boyter commented Feb 18, 2024

It should be used by the compiler when building from source. I also keep it so I have a reliable way to access them. Also I hate projects where you clone, then spend 30 mins waiting for dependencies before being able to build.

I guess I also watched a company grind to a halt when left-pad happened while I was trucking on.

@steverusso
Copy link
Contributor Author

Haha fair enough, good points. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants