Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strings.EqualFold in case-insensitive comparisons #479

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Use strings.EqualFold in case-insensitive comparisons #479

merged 1 commit into from
Jun 10, 2024

Conversation

apocelipes
Copy link
Contributor

strings.EqualFold is simpler and much faster than strings.ToLower.

@apocelipes
Use strings.EqualFold in case-insensitive comparisons
41a3884 
`strings.EqualFold` is simpler and much faster than `strings.ToLower`.
@apocelipes
Copy link
Contributor Author

apocelipes commented Jun 10, 2024 •
edited
Loading

Irrelative failure, seems like 624d6c5's code ran into some problems.

Update: This error may be fixed by #480

@ccoVeille ccoVeille mentioned this pull request Jun 10, 2024
Merged
@boyter
Copy link
Owner

boyter commented Jun 10, 2024

Neat. One of those ones that I am sure had I written it today would have picked up. Thanks.

@boyter boyter merged commit bc111c9 into boyter:master Jun 10, 2024
4 of 5 checks passed
@apocelipes apocelipes deleted the feat-equal-fold branch July 2, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apocelipes @boyter @ccoVeille