Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Requestion: Add some additional extensions logic #146

Closed
NathanaelA opened this issue Sep 13, 2017 · 4 comments
Closed

Feature Requestion: Add some additional extensions logic #146

NathanaelA opened this issue Sep 13, 2017 · 4 comments

Comments

@NathanaelA
Copy link

Typescript by default uses .ts as its extension. It also has .d.ts to stand for typings. I would like to categorize the .d.ts files as "Typings" and leave the .ts and Typescript. However, even though I attempted to add a d.ts file to the list both before and after the ts in the list; all the .d.ts files were cataloged as typescript files.

I would like to be able to have the matching algorithm be smart enough to know that a .d.ts is different than a .ts file.

@boyter
Copy link
Owner

boyter commented Sep 14, 2017

Not a problem. I need to make a few modifications to the way the classification works to get this going but not a huge issue.

@NathanaelA
Copy link
Author

Awesome, this one actually is a annoying pain. I search for something and get the .d.ts in the search results, and can't eliminate them by picking .ts since they are classified as .ts. But I need them indexed because people will want to search just the typings too... Looking forward to when this gets fixed. Thanks!

@boyter
Copy link
Owner

boyter commented Sep 15, 2017

Yep Its mostly there. I just need to add the logic to pick which one is correct when both match. Going to make it go for the longest one IE the best fitting match. Then will merge.

I will add it to the classifier database as well for you,

{
    "language": "Typings Definition",
    "extensions": [
      "d.ts"
    ],
    "keywords": []
  }

boyter added a commit that referenced this issue Sep 15, 2017
@boyter
Copy link
Owner

boyter commented Sep 15, 2017

Sitting in master. Added a variety of new tests for it and verified against a sample repository.

screen shot 2017-09-15 at 5 46 08 pm

@boyter boyter closed this as completed Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants