Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _blocked_well.py to ensure dtype is maintained when adding grid property #733

Merged
merged 6 commits into from
Jun 22, 2023

Conversation

emmanesbit
Copy link
Contributor

@emmanesbit emmanesbit commented Jun 21, 2023

This minor edit ensures the dtype of the original property array is maintained when adding property to blocked well from a grid.

There is also an update to the unit tests for this code to add a continuous property, and check the dtype of one continuous and one discrete property are correct.

Ensure dtype is maintained
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (67e4268) 80.91% compared to head (8406f6d) 80.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #733   +/-   ##
=======================================
  Coverage   80.91%   80.92%           
=======================================
  Files         190      190           
  Lines       32377    32377           
=======================================
+ Hits        26199    26200    +1     
+ Misses       6178     6177    -1     
Impacted Files Coverage Δ
resqpy/well/_blocked_well.py 82.92% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@emmanesbit emmanesbit added the bug Something isn't working label Jun 21, 2023
@andy-beer andy-beer merged commit 01ab596 into master Jun 22, 2023
10 checks passed
@andy-beer andy-beer deleted the bwell_grid_prop_dtype branch October 17, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants